refactor: split env in to tokens for further duplicates check

Signed-off-by: Artur Troian <[email protected]>

go/manifest/v2beta2/manifest_test.go

@@ -274,7 +274,7 @@ func TestManifestWithEmptyEnvNameIsInvalid(t *testing.T) {
 	m[0].Services[0].Env = envVars
 	err := m.Validate()
 	require.Error(t, err)
-	require.Regexp(t, `^.*var\. with an empty name.*$`, err)
+	require.Regexp(t, `^.*var\. with an invalid name.*$`, err)
 }
 
 func TestManifestWithBadEnvNameIsInvalid(t *testing.T) {

go/manifest/v2beta2/service.go

@@ -29,17 +29,12 @@ func (s *Service) validate(helper *validateManifestGroupsHelper) error {
 	}
 
 	for _, envVar := range s.Env {
-		idx := strings.Index(envVar, "=")
-		if idx == 0 {
+		tokens := strings.SplitN(envVar, "=", 2)
+		if len(tokens) == 0 {
 			return fmt.Errorf("%w: service %q defines an env. var. with an empty name", ErrInvalidManifest, s.Name)
 		}
 
-		var envVarName string
-		if idx > 0 {
-			envVarName = envVar[0:idx]
-		} else {
-			envVarName = envVar
-		}
+		envVarName := tokens[0]
 
 		if 0 != len(k8svalidation.IsEnvVarName(envVarName)) {
 			return fmt.Errorf("%w: service %q defines an env. var. with an invalid name %q", ErrInvalidManifest, s.Name, envVarName)