Add Kali backport #180
Open
Add Kali backport #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic facing URL to access
n0vabyte
reviewed
Dec 19, 2024
Comment on lines
+8
to
+10
| - name: Update apt cache | ||
| apt: | ||
| update_cache: yes |
There was a problem hiding this comment.
Remove this task. This is redundant with the next task.
There was a problem hiding this comment.
The only thing that we should have in this file is import_tasks. Break everything out into their own task file if possible to stick to the standard.
Comment on lines
+12
to
+26
| - name: Create VNC user | ||
| user: | ||
| name: "{{ vnc_username }}" | ||
| password: "{{ vnc_password | password_hash('sha512') }}" | ||
| shell: /bin/bash | ||
|
|
||
| - name: Set up VNC password | ||
| expect: | ||
| command: vncserver | ||
| responses: | ||
| Password: "{{ vnc_password }}" | ||
| Verify: "{{ vnc_password }}" | ||
| "Would you like to enter a view-only password (y/n)?": "n" | ||
| become: yes | ||
| become_user: "{{ vnc_username }}" |
There was a problem hiding this comment.
This output to the log. Use no_log to avoid leaking secrets to the stackscript log.
| kali_package: "{{ 'kali-linux-everything' if '${EVERYTHING}' == 'Yes' else 'kali-linux-headless' if '${HEADLESS}' == 'Yes' else '' }}" | ||
|
|
||
| # VNC settings | ||
| vnc_enabled: "{{ '${VNC}' == 'Yes' }}" |
There was a problem hiding this comment.
We are making boolean conditional in the playbook. This is a string. We need to translate 'Yes' or 'No' to either be True or False in the vars file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.