Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @lru_cache-clearing Pytest fixture at test module level, not in function signatures #462

Closed
wants to merge 1 commit into from

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Jan 30, 2023

Test function signatures are cleaner if the find_project_root_cache_clear fixture is omitted and instead added at the module level. It's not that expensive, so doesn't matter if it's used also for test functions which don't require it.

@akaihola akaihola added the CI label Jan 30, 2023
@akaihola akaihola added this to the 1.7.1 milestone Jan 30, 2023
@akaihola akaihola self-assigned this Jan 30, 2023
@akaihola akaihola changed the title Use lru_cache clear fixture at test module level Use @lru_cache-clearing Pytest fixture at test module level, not in function signatures Jan 30, 2023
@akaihola akaihola modified the milestones: 1.7.1, 1.7.2 Feb 19, 2023
@akaihola akaihola force-pushed the module-global-fixture branch from f8f36ee to fbaea9a Compare March 25, 2023 18:50
@akaihola akaihola modified the milestones: Darker 1.7.2, Darker 1.8.1 Mar 26, 2023
@akaihola akaihola force-pushed the module-global-fixture branch from fbaea9a to 09089f4 Compare March 26, 2023 11:22
@akaihola akaihola force-pushed the module-global-fixture branch from 09089f4 to 9d3e49e Compare June 7, 2023 20:41
@akaihola akaihola force-pushed the module-global-fixture branch from 9d3e49e to e78979b Compare July 14, 2023 15:38
@akaihola akaihola force-pushed the module-global-fixture branch from e78979b to 0c20863 Compare March 11, 2024 20:58
@akaihola
Copy link
Owner Author

Obsolete, fixed earlier in another PR.

@akaihola akaihola closed this Mar 16, 2024
@akaihola akaihola deleted the module-global-fixture branch March 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant