Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added functionality for re-indexing footnotes automatically.
To achieve this I mostly re-wrote the
shouldCreateNewFootnote()
function.The new footnote ID is determined by just searching for the biggest footnote before the current cursor position.
Then all IDs bigger or equal to that get incremented.
Lastly the new footnote marker and detail get added.
Regarding the edge cases:
Footnote details get added before the next one. So not an issue.
Not an issue since only bigger IDs ever get incremented. New footnote is only added afterwards.
Not an issue since the correct position is just searched for everywhere after the cursor (could be changed to everywhere maybe?)
Not an issue as the new detail line is placed just before the next one.
Get ignored for now.