Merge pull request #73 from ajolma/issue_61_test_dirs

Tests: use Test::TempDir::Tiny and Path::Tiny

.github/workflows/linux_bin_build.yml

@@ -48,6 +48,8 @@ jobs:
           cpanm --notest Test::Exception
           cpanm --notest JSON
           cpanm --notest PDL
+          cpanm --notest Path::Tiny
+          cpanm --notest Test::TempDir::Tiny
   
       - name: Build
         run: |

.github/workflows/linux_share_build.yml

@@ -49,6 +49,8 @@ jobs:
           cpanm --notest local::lib
           echo $(perl -Mlocal::lib=${HOME}/perl5)
           eval "$(perl -Mlocal::lib=${HOME}/perl5)"
+          cpanm --notest Path::Tiny
+          cpanm --notest Test::TempDir::Tiny
           cpanm --notest PDL
           cpanm --notest Alien::Build
           cpanm --installdeps --notest Alien::sqlite

.github/workflows/linux_sys_build.yml

@@ -57,6 +57,8 @@ jobs:
           cpanm --notest local::lib
           echo $(perl -Mlocal::lib=${HOME}/perl5)
           eval "$(perl -Mlocal::lib=${HOME}/perl5)"
+          cpanm --notest Path::Tiny
+          cpanm --notest Test::TempDir::Tiny
           cpanm --notest PDL
           cpanm --notest Alien::Build
           cpanm --installdeps --notest Alien::sqlite

.github/workflows/macos.yml

@@ -56,6 +56,8 @@ jobs:
 
       - name: Install Dynamic Dependencies
         run: |
+          cpanm --notest Path::Tiny
+          cpanm --notest Test::TempDir::Tiny
           cpanm --notest PDL
           cpanm --notest Alien::Build
           cpanm --notest Alien::Build::MM

.github/workflows/macos_share_builds.yml

@@ -45,6 +45,8 @@ jobs:
 
       - name: Install Dynamic Dependencies
         run: |
+          cpanm --notest Path::Tiny
+          cpanm --notest Test::TempDir::Tiny
           cpanm --notest PDL
           cpanm --notest Alien::Build
           cpanm --notest Alien::Build::MM

Makefile.PL

@@ -83,10 +83,12 @@ my %args = (
         'Alien::gdal' => 0,
     },
     TEST_REQUIRES => {
-        'Test::More' => 0,
-        'Test::Exception' => 0,
-        'JSON' => 0,
-        'Data::Dumper' => 0
+        'Test::More'          => 0,
+        'Test::Exception'     => 0,
+        'JSON'                => 0,
+        'Data::Dumper'        => 0,
+        'Path::Tiny'          => 0,
+        'Test::TempDir::Tiny' => 0,
     },
     META_MERGE => {
         "meta-spec" => { version => 2 },

t/00.t

@@ -7,6 +7,8 @@ use Encode qw(decode encode);
 use Test::More;
 use Data::Dumper;
 use JSON;
+use Test::TempDir::Tiny;
+use Path::Tiny qw/path/;
 
 BEGIN { use_ok('Geo::GDAL::FFI', qw/:all/); }
 
@@ -286,8 +288,10 @@ if(1){
 
 # test creating a shapefile
 if(1){
+    my $dir = tempdir();
+    my $testfile = path($dir, 'test.shp');
     my $dr = GetDriver('ESRI Shapefile');
-    my $ds = $dr->Create('test.shp');
+    my $ds = $dr->Create($testfile);
     my @sr = ();
     if (FindFile('gcs.csv')) {  #  should be version checked? GDAL 3 does not use gcs.csv
         @sr = (SpatialReference => Geo::GDAL::FFI::SpatialReference->new(EPSG => 3067));
@@ -297,11 +301,10 @@ if(1){
     my $f = Geo::GDAL::FFI::Feature->new($d);
     $l->CreateFeature($f);
     undef $l; #  otherwise $ds is not flushed due to parent ref
-    $ds = Open('test.shp');
+    $ds = Open($testfile);
     $l = $ds->GetLayer;
     $d = $l->GetDefn();
     ok($d->GetGeomType eq 'Point', "Create point shapefile and open it.");
-    unlink qw/test.dbf test.prj test.shp test.shx/;
 }
 
 # test field definitions

t/dataset.t

@@ -6,8 +6,12 @@ use Geo::GDAL::FFI qw/GetDriver HaveGEOS/;
 use Test::More;
 use Test::Exception;
 use Data::Dumper;
+use Test::TempDir::Tiny;
+use Path::Tiny qw/path/;
 
-my $ds = GetDriver('GPKG')->Create('test.gpkg');
+my $dir = tempdir();
+my $gpkg_file = path ($dir, 'test.gpkg');
+my $ds = GetDriver('GPKG')->Create($gpkg_file);
 my $sr = Geo::GDAL::FFI::SpatialReference->new(EPSG => 3067);
 foreach my $i (1..3) {
     my $l = $ds->CreateLayer({

t/dataset_rasterize.t

@@ -5,6 +5,8 @@ use warnings;
 use Geo::GDAL::FFI;
 
 use Test::More;
+use Test::TempDir::Tiny;
+use Path::Tiny qw/path/;
 
 local $| = 1;
 
@@ -165,8 +167,10 @@ sub test_Rasterize {
 
 
 sub get_test_raster {
-    my $name = 'test_ras' . (time() + rand()) . '.tiff';
-    my $tiff = Geo::GDAL::FFI::GetDriver('GTiff')->Create('test.tiff', 3, 2);
+    my $dir = tempdir();
+    # my $name = 'test_ras' . time() + rand() . '.tiff';
+    my $tiff_file = path ($dir, 'test.tiff');
+    my $tiff = Geo::GDAL::FFI::GetDriver('GTiff')->Create($tiff_file, 3, 2);
     my $ogc_wkt = 
            'GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS84",6378137,298.257223563,'.
            'AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,'.

t/open.t

@@ -8,9 +8,14 @@ use Test::More;
 use Data::Dumper;
 use JSON;
 use FFI::Platypus::Buffer;
+use Path::Tiny qw/path/;
+use Test::TempDir::Tiny;
+
+my $dir = tempdir();
+my $testfile = path($dir, 'test.shp');
 
 {
-    my $ds = GetDriver('ESRI Shapefile')->Create('test.shp');
+    my $ds = GetDriver('ESRI Shapefile')->Create($testfile);
     my $sr = Geo::GDAL::FFI::SpatialReference->new(EPSG => 3067);
     my $l = $ds->CreateLayer({Name => 'test', SpatialReference => $sr, GeometryType => 'Point'});
     my $d = $l->GetDefn();
@@ -21,7 +26,7 @@ use FFI::Platypus::Buffer;
 my $ds;
 
 eval {
-    $ds = Open('test.shp', {
+    $ds = Open($testfile, {
         Flags => [qw/READONLY VERBOSE_ERROR/], 
         AllowedDrivers => [('GML')]
     });
@@ -31,13 +36,11 @@ $e[0] =~ s/ at .*//;
 ok($@, "Right driver not in AllowedDrivers: ".$e[0]);
 
 eval {
-    $ds = Open('test.shp', {
+    $ds = Open($testfile, {
         Flags => [qw/READONLY VERBOSE_ERROR/], 
         AllowedDrivers => [('GML', 'ESRI Shapefile')]
     });
 };
 ok(!@$, "Require right driver in AllowedDrivers");
 
-unlink qw/test.dbf test.prj test.shp test.shx/;
-
 done_testing();