connection.py: do not send messages when mail.suppress is set #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorben
force-pushed
the
khorben/mail-suppress
branch
from
851cba9 to
4951113
Compare
khorben
changed the title
khorben
force-pushed
the
khorben/mail-suppress
branch
from
4951113 to
2eabfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that neither
app.testingfrom Flask nor theMAIL_SUPPRESS_SENDconfiguration variable are ever enforced, even through theMail.suppressclass member. This patch should actually implement the behaviour expected as documented, actually preventing sending e-mails when they should not be sent.