Fixing Request Type #399
Fixing Request Type #399
Conversation
| // videoID already exists | ||
| const destMatch = dest.find(s => s.videoID === obj.videoID); | ||
| if (destMatch) { | ||
| if (videoID in dest) { |
There was a problem hiding this comment.
solving in O(1) instead of O(n^2)
| categories: Category[]; | ||
| userID: UserID | HashedUserID; | ||
| } | ||
| } |
There was a problem hiding this comment.
simplified interface for what the request actually looks like.
There was a problem hiding this comment.
adminID is always of type userID
** will comment on file itself
There was a problem hiding this comment.
most types are available here https://github.com/mchangrh/sb-openapi-source/blob/main/openapi.yaml
or https://wiki.sponsor.ajay.app/index.php/API_Docs
if you have any questions about types, just @ me on the discord blabdude#9793
| adminUserID: string; | ||
| enabled: string; | ||
| generate: "true" | "false"; | ||
| service: "youtube" | "vimeo"; |
There was a problem hiding this comment.
services are in src/types/segments.model.s
| videoID: VideoID; | ||
| userID: UserID | HashedUserID; | ||
| adminUserID: string; | ||
| enabled: string; |
| query: { | ||
| videoID: VideoID; | ||
| userID: UserID | HashedUserID; | ||
| adminUserID: string; |
There was a problem hiding this comment.
adminUserID is of type UserID
| channelID: string, | ||
| service: string, | ||
| categories: Category[]; | ||
| userID: UserID | HashedUserID; |
There was a problem hiding this comment.
userID retuned should always be HashedUserID
|
Extracted the performance fix to 8759f8d |
This is a continuation of #390 so it has commits from that too.
In this PR:
Requesttype intoAPIRequestsimplifying the request interface.