[WIP] Refactors interruptions into the output device #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: refactor out interruptions from StreamingConversation into the output device so that other pipelines can take advantage of a single interface for output device
goals:
allow conversation to just send chunks to output device without having to worry about rate limiting / mark messages
allow output device to dispatch back into conversation with on_play / on_interrupt callbacks to control
consolidate twilio's interruptions into the output device so the
send_speech_to_outputmethod remains the same across all conversationsresolve todos
add tests
e2e test transcript
e2e test interruptions
test vonage