bug #43
Open
bug #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the scrapy will report using proxy <http://XXX.XXX.XXX.XXX> but actually it not.
ravillarreal
approved these changes
Sep 11, 2019
BriungRi
approved these changes
Nov 9, 2019
There was a problem hiding this comment.
Not sure if I have enough context to know if there are consequences to this bug fix. That said, this does look like a bug where a value is not set for both the user:pass and non user:pass cases. I made this custom change to my own randomproxy.py and I was able to verify that this fixes the non user:pass case by querying http://api.ipify.org and getting back the proxy IP. Before the fix, I would get my own local IP which was not expected.
Would be great if this change could be merged into master since I can't imagine this package being usable without it actually proxying for the non user:pass case.
catapulta
approved these changes
Sep 24, 2020
|
Commenting to just bump this up, this is much needed. Please merge it!! |
vignesh-reddy
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when proxy url like this http://XXX.XXX.XXX.XXX without user:passwd, the scrapy will report using proxy http://XXX.XXX.XXX.XXX but actually it not.