feature: ネストされた名前空間下の変数を参照できるように (#629) #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FineArchs
approved these changes
Apr 21, 2024
Closed
salano-ym
approved these changes
Apr 21, 2024
|
ありがとうございます！ |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ネストされた名前空間下の変数を参照できるようになります。
Why
#629 ネストした名前空間下の変数を参照できなかった
Additional info (optional)
API の変更点:
ScopeクラスにプロパティnsName?: stringを追加し、接頭辞付きの変数を親スコープに追加するコードをScope#addメソッドに移動しました。