fn #210
Open
fn #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 77.41% // Head: 77.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 20 20
Lines 2759 2759
Branches 426 426
=======================================
Hits 2136 2136
Misses 615 615
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marihachi
reviewed
Aug 30, 2022
| @@ -501,10 +501,10 @@ Args | |||
| // define function statement | |||
|
|
|||
| FnDef | |||
| = "@" s1:__* name:NAME s2:__* "(" _* args:Args? _* ")" ret:(_* ":" _* @Type)? _* "{" _* content:Statements? _* "}" | |||
| = "fn" _+ name:NAME s1:__* "(" _* args:Args? _* ")" _* ret:(_* "=>" _* @Type)? _* "{" _* content:Statements? _* "}" | |||
There was a problem hiding this comment.
これって:は型の指定をする時の記号だけど、これを=>にするという意図？
There was a problem hiding this comment.
あーそう
ついでに=>にしてみた(Rustとかだとそう)
marihachi
reviewed
Aug 30, 2022
| @@ -516,7 +516,7 @@ FnDef | |||
|
|
|||
| // function expression | |||
|
|
|||
| Fn = "@(" _* args:Args? _* ")" ret:(_* ":" _* @Type)? _* "{" _* content:Statements? _* "}" | |||
| Fn = "(" _* args:Args? _* ")" _* ret:(_* ":" _* @Type)? _* "=>" _* "{" _* content:Statements? _* "}" | |||
There was a problem hiding this comment.
ありふれている記号列ではスペースや改行の扱いはよく検討する必要がありそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #179
Why
Additional info (optional)