BUG: fix extraction of conda version #1428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a conda environment, the conda version is checked to determine the syntax of the command.
However, the version is currently extracted incorrectly. The command
conda --version
returnsconda xx.xx.xx
rather than the version stringxx.xx.xx
as the code assumes.As a result, for conda version
23.3.1
, we haveconda_version = "conda 23.3.1"
andconda_version >= "24.3.0"
is evaluated asTrue
, when it should beFalse
.This PR:
conda --version
command, andpackaging.version.Version
for a safer comparison of version strings.It also pins setuptools following the recommendation given in PR #1426 to ensure CI passes.
Question:
Should we test that environments are created correctly for different conda versions?