This repository has been archived by the owner on May 18, 2021. It is now read-only.
Fix bugs with allow-duplicate-installations-on-an-agent. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| this.coordinator = coordinator; | ||
| this.repository = repository; | ||
| this.config = config; |
There was a problem hiding this comment.
Configs are mutable, so the values should be extracted and stored in the constructor
- Make sure that the config setting is respected everywhere. - If less agents than requested installs are present and duplicate installation is allowed, install more than one instance of a service per agent.
hgschmie
force-pushed
the
duplicate-fixes
branch
from
f4e5569
to
de5e340
Compare
hgschmie
force-pushed
the
duplicate-fixes
branch
from
de5e340
to
f849162
Compare
|
fixed |
| } | ||
|
|
||
| int totalInstalls = limit; | ||
| int installsPerHost = allowDuplicateInstallationsOnAnAgent ? limit / candidateAgents.size() : 1; |
There was a problem hiding this comment.
I think this only works if limit divides evenly into the nodes. For example if you have a target of 10 and 3 nodes you will only get nine installations.
There was a problem hiding this comment.
I Presto when doing stuff like this, we use:
candidateAgents = Iterables.limit(Iterables.cycle(candidateAgents), limit);
Once you have that, I think you can simply pass it to the existing logic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more than one instance of a service per agent.