Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing squid:S1604 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Using diamond operator
alainlompo committed Nov 4, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit fcf70c7a093b9538e9a171575cd30019f1d7c5ae
4 changes: 2 additions & 2 deletions src/main/java/io/airlift/airline/Accessor.java
Original file line number Diff line number Diff line change
@@ -146,10 +146,10 @@ public String toString()
private static Collection<Object> newCollection(Class<?> type)
{
if (Collection.class.equals(type) || List.class.equals(type)) {
return new ArrayList<Object>();
return new ArrayList<>();
}
if (Set.class.equals(type)) {
return new HashSet<Object>();
return new HashSet<>();
}
if (SortedSet.class.equals(type)) {
return new TreeSet();
6 changes: 3 additions & 3 deletions src/main/java/io/airlift/airline/Cli.java
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ public class Cli<C>
public static <T> CliBuilder<T> builder(String name)
{
Preconditions.checkNotNull(name, "name is null");
return new CliBuilder<T>(name);
return new CliBuilder<>(name);
}

@Deprecated
@@ -281,14 +281,14 @@ public GroupBuilder<C> withGroup(String name)
return groups.get(name);
}

GroupBuilder<C> group = new GroupBuilder<C>(name);
GroupBuilder<C> group = new GroupBuilder<>(name);
groups.put(name, group);
return group;
}

public Cli<C> build()
{
return new Cli<C>(name, description, typeConverter, defaultCommand, defaultCommandGroupCommands, groups.values());
return new Cli<>(name, description, typeConverter, defaultCommand, defaultCommandGroupCommands, groups.values());
}
}

2 changes: 1 addition & 1 deletion src/main/java/io/airlift/airline/CommandUsage.java
Original file line number Diff line number Diff line change
@@ -147,7 +147,7 @@ public void usage(@Nullable String programName, @Nullable String groupName, Stri
private List<OptionMetadata> sortOptions(List<OptionMetadata> options)
{
if (optionComparator != null) {
options = new ArrayList<OptionMetadata>(options);
options = new ArrayList<>(options);
Collections.sort(options, optionComparator);
}
return options;
2 changes: 1 addition & 1 deletion src/main/java/io/airlift/airline/SingleCommand.java
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ public class SingleCommand<C>
{
public static <C> SingleCommand<C> singleCommand(Class<C> command)
{
return new SingleCommand<C>(command);
return new SingleCommand<>(command);
}

private final CommandMetadata commandMetadata;