Add @SafeVarargs annotation to Cli.java #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Cli.CliBuilder and Cli.GroupBuilder have
public CliBuilder<C> withCommands(Class<? extends C> command, Class<? extends C>... moreCommands);
public GroupBuilder<C> withCommands(Class<? extends C> command, Class<? extends C>... moreCommands)
Both of them use the `moreCommands` array in a typesafe way, which means
they could be annotated with @SafeVarargs. They were not, though, which
generates unchecked warnings at call sites.
Note that the methods must be made final for SafeVarargs to be valid.
A description of SafeVarargs is
https://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.6.4.7
Test plan: `mvn clean verify` passes on 8u141
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cli.CliBuilder and Cli.GroupBuilder have
Both of them use the
moreCommandsarray in a typesafe way, which meansthey could be annotated with @SafeVarargs. They were not, though, which
generates unchecked warnings at call sites.
Note that the methods must be made final for SafeVarargs to be valid.
A description of SafeVarargs is
https://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.6.4.7
Test plan:
mvn clean verifypasses on 8u141