Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix javadoc plugin configuration when JDK preview features used #405

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix javadoc plugin configuration when JDK preview features used #405

merged 1 commit into from
Apr 9, 2024

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Apr 4, 2024

No description provided.

@findepi
Copy link
Contributor Author

findepi commented Apr 4, 2024

cc @electrum @wendigo

@findepi
Copy link
Contributor Author

findepi commented Apr 4, 2024

relates to #404

@wendigo
Copy link
Contributor

wendigo commented Apr 4, 2024

This still doesn't work in IntelliJ. I think that this is due to the fact that air.compiler.enable-preview is evaluated to produce surefireEnablePreview in the build-helper-maven-plugin which is not something that IntelliJ understands and support.

@wendigo
Copy link
Contributor

wendigo commented Apr 4, 2024 •
edited
Loading

I think that instead of air.compiler.enable-preview we should introduce air.compiler.extra-args and pass it directly rather than through bsh-property

@findepi
Copy link
Contributor Author

findepi commented Apr 4, 2024

This still doesn't work in IntelliJ.

That's not the point of this PR.

This PR fixes building with mvn verify for the case where the Java code relies on features accessible with --enable-preview. Without this, the javadoc processing fails at symbol/class resolution.

@wendigo
Copy link
Contributor

wendigo commented Apr 4, 2024

@findepi this would work

@findepi findepi force-pushed the findepi/fix-javadoc-plugin-configuration-when-jdk-preview-features-used-942ac3 branch from 47c98e1 to 7cba31f Compare April 5, 2024 13:07
@findepi
Copy link
Contributor Author

findepi commented Apr 5, 2024

updated CHANGES

@findepi
Copy link
Contributor Author

findepi commented Apr 5, 2024

@electrum would you like to take a look?

@electrum electrum merged commit 2a63068 into airlift:master Apr 9, 2024
2 checks passed
@findepi findepi deleted the findepi/fix-javadoc-plugin-configuration-when-jdk-preview-features-used-942ac3 branch April 9, 2024 21:46
@findepi findepi mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @wendigo @electrum