Remove CORE_DEBUG_LEVEL that affected PM sensor reading #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And change it to airgradient log level that take effect to airgradient submodules Temporary bump submodule to WIP branch
nick-4711
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
So turns out
CORE_DEBUG_LEVELbuild flag is usingSerial0which is connected to PM sensor that makes PM sensor send error measures values, even though USB_CDC is enabled,.Solutions
CORE_DEBUG_LEVELbuild flag is used by airgradient libraries (airgradient-client and airgradient-ota) to print out esp_log. Now the libs using custom log macros to handle two environments which are Arduino and ESP-IDF soCORE_DEBUG_LEVELcan be removed.The libs expecting
AG_LOG_LEVELdefined so agLogger.h able to compile the target log level needed.Notes: This PR temporarily link airgradient libs submodule to WIP branch. Will be changed after PR on those libs are merged.