Add Label 24 / Parsing #166
Conversation
- eta can be seconds in day (tod) or seconds since epoch - airports can be icao or iata
|
I might split this up - I did the eta/airport normalization for label 5Z but didn't realize i had Label 24 work in here |
| expect(decodeResult.formatted.items[1].code).toBe('ORG'); | ||
| expect(decodeResult.formatted.items[1].label).toBe('Origin'); | ||
| expect(decodeResult.formatted.items[1].value).toBe('KJFK'); | ||
| expect(decodeResult.formatted.items[2].type).toBe('destination'); | ||
| expect(decodeResult.formatted.items[2].type).toBe('icao'); |
There was a problem hiding this comment.
Should we not instead do destination_icao?
There was a problem hiding this comment.
so i'm trying to make the item as follows
type - kind of thing it is - time of day, time since epoch, icao code, etc
code - unique identifier for what it is
label - display of what it is
value - display of the actual value
so in this case it's
type: icao (4-character airport code)
code: DST
label: Destination Airport
value: KUZA
Open to suggestions. will keep this open to discuss
There was a problem hiding this comment.
I think you're right here. Maybe we need an additional element called name?
There was a problem hiding this comment.
mmmm - i see the label as the "human name" and code as the "computer name" and the type as a "units". IDK, it's gotten messy and i tried to commandeer type because 3 variations of "destination" or any other value seemed excessive
There was a problem hiding this comment.
i wrote this and then there's also the raw value. sigh
Normalize eta and airports