Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label 24 / parsing #165

Merged
merged 3 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/MessageDecoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class MessageDecoder {
this.registerPlugin(new Plugins.Label_16_N_Space(this));
this.registerPlugin(new Plugins.Label_20_POS(this));
this.registerPlugin(new Plugins.Label_21_POS(this));
this.registerPlugin(new Plugins.Label_24_Slash(this));
this.registerPlugin(new Plugins.Label_30_Slash_EA(this));
this.registerPlugin(new Plugins.Label_44_ETA(this));
this.registerPlugin(new Plugins.Label_44_IN(this));
Expand Down
55 changes: 55 additions & 0 deletions lib/plugins/Label_24_Slash.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import { MessageDecoder } from '../MessageDecoder';
import { Label_24_Slash } from './Label_24_Slash';

describe('Label_24_Slash', () => {
let plugin: Label_24_Slash;

beforeEach(() => {
const decoder = new MessageDecoder();
plugin = new Label_24_Slash(decoder);
});

test('matches qualifiers', () => {
expect(plugin.decode).toBeDefined();
expect(plugin.name).toBe('label-24-slash');
expect(plugin.qualifiers).toBeDefined();
expect(plugin.qualifiers()).toEqual({
labels: ['24'],
preambles: ['/'],
});
});


test('valid', () => {
// https://app.airframes.io/messages/3439806391
const text = '/241710/1021/04WM/34962/N53.13/E001.33/3374/1056/';
const decodeResult = plugin.decode({ text: text });
expect(decodeResult.decoded).toBe(true);
expect(decodeResult.decoder.decodeLevel).toBe('partial');
expect(decodeResult.raw.message_timestamp).toBe(1729160460);
expect(decodeResult.raw.flight_number).toBe('04WM');
expect(decodeResult.raw.altitude).toBe(34962);
expect(decodeResult.raw.position.latitude).toBe(53.13);
expect(decodeResult.raw.position.longitude).toBe(1.33);
expect(decodeResult.raw.eta_time).toBe(39360);
expect(decodeResult.formatted.items.length).toBe(3);
makrsmark marked this conversation as resolved.
Show resolved Hide resolved
expect(decodeResult.formatted.items[0].label).toBe('Altitude');
expect(decodeResult.formatted.items[0].value).toBe('34962 feet');
expect(decodeResult.formatted.items[1].label).toBe('Aircraft Position');
expect(decodeResult.formatted.items[1].value).toBe('53.130 N, 1.330 E');
expect(decodeResult.formatted.items[2].label).toBe('Estimated Time of Arrival');
expect(decodeResult.formatted.items[2].value).toBe('10:56:00');

expect(decodeResult.remaining.text).toBe('3374');
});

test('does not decode invalid', () => {

const text = '/ Bogus message';
const decodeResult = plugin.decode({ text: text });

expect(decodeResult.decoded).toBe(false);
expect(decodeResult.decoder.decodeLevel).toBe('none');
expect(decodeResult.message.text).toBe(text);
});
});
56 changes: 56 additions & 0 deletions lib/plugins/Label_24_Slash.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import { DateTimeUtils } from '../DateTimeUtils';
import { DecoderPlugin } from '../DecoderPlugin';
import { DecodeResult, Message, Options } from '../DecoderPluginInterface';
import { ResultFormatter } from '../utils/result_formatter';

// Position Report
export class Label_24_Slash extends DecoderPlugin {
name = 'label-24-slash';

qualifiers() { // eslint-disable-line class-methods-use-this
return {
labels: ['24'],
preambles: ['/'],
};
}

decode(message: Message, options: Options = {}) : DecodeResult {
const decodeResult = this.defaultResult();
decodeResult.decoder.name = this.name;
decodeResult.formatted.description = 'Position Report';
decodeResult.message = message;

const fields = message.text.split('/');

if (fields.length == 10 && fields[0] == '' && fields[9] == '') { // begin and ends with `/`
const mmddyy = fields[1].substring(4,6) + fields[1].substring(2,4) + fields[1].substring(0,2); // YYDDMM
const hhmmss = fields[2] + '00';
decodeResult.raw.message_timestamp = DateTimeUtils.convertDateTimeToEpoch(hhmmss,mmddyy);
ResultFormatter.flightNumber(decodeResult, fields[3]);
ResultFormatter.altitude(decodeResult, Number(fields[4]));
const lat = fields[5];
const lon = fields[6];
const position = {
latitude: (lat[0] === 'N' ? 1 : -1) * Number(lat.substring(1)),
longitude: (lon[0] === 'E' ? 1 : -1) * Number(lon.substring(1)),
};
ResultFormatter.position(decodeResult, position);
ResultFormatter.eta(decodeResult, DateTimeUtils.convertHHMMSSToTod(fields[8]+'00'));
decodeResult.remaining.text = fields[7];

decodeResult.decoded = true;
decodeResult.decoder.decodeLevel = 'partial';
} else {
// Unknown!
if(options.debug) {
console.log(`DEBUG: ${this.name}: Unknown variation. Field count: ${fields.length}. Message: ${message.text}`);
}
decodeResult.decoded = false;
decodeResult.decoder.decodeLevel = 'none';
}
return decodeResult;
}
}

export default {};

1 change: 1 addition & 0 deletions lib/plugins/official.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export * from './Label_16_N_Space';
export * from './Label_1M_Slash';
export * from './Label_20_POS';
export * from './Label_21_POS';
export * from './Label_24_Slash';
export * from './Label_30_Slash_EA';
export * from './Label_44_ETA';
export * from './Label_44_IN';
Expand Down