More H1 matching #163
Merged
More H1 matching #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to decode H1 messages from c-band. If decode is not successful, it will try the next possible decoder - cleanup of unit tests - remove 'fullyDecoded' flags being passed around in H1Helper
makrsmark
commented
Oct 16, 2024
Comment on lines
+126
to
+131
| for (let i = 0; i < usablePlugins.length; i++) { | ||
| const plugin = usablePlugins[i]; | ||
| result = plugin.decode(message); | ||
| } else { | ||
| result = { | ||
| decoded: false, | ||
| error: 'No known decoder plugin for this message', | ||
| decoder: { | ||
| name: 'none', | ||
| type: 'none', | ||
| decodeLevel: 'none', | ||
| }, | ||
| message: message, | ||
| remaining: { | ||
| text: message.text, | ||
| }, | ||
| raw: {}, | ||
| formatted: { | ||
| description: 'Not Decoded', | ||
| items: [], | ||
| }, | ||
| }; | ||
| if (result.decoded) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
this is important - moving from grabbing the first match, to running in order and stopping if we successfully decoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to decode H1 messages from c-band. If decode is not successful, it will try the next possible decoder