Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (source-shopify) - deprecate an old ProductGraphQL and CustomerSavedSearch streams from the stream catalog #51037

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ acceptance_tests:
discovery:
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
# the `ProductGraphQL`, `CustomerSavedSearch` were removed from the stream catalog,
# because of the deprecation notice: https://shopify.dev/docs/api/release-notes/2024-04
disable_for_version: "2.5.17"
basic_read:
tests:
- config_path: "secrets/config_transactions_with_user_id.json"
Expand All @@ -35,8 +39,6 @@ acceptance_tests:
bypass_reason: The stream holds data up to 1 month then records are removed by Shopify.
- name: balance_transactions
bypass_reason: The stream requires real purchases to fill in the data.
- name: customer_saved_search
bypass_reason: The stream is not available for our sandbox.
- name: disputes
bypass_reason: The stream requires real purchases to fill in the data.
- config_path: "secrets/config.json"
Expand All @@ -48,8 +50,6 @@ acceptance_tests:
bypass_reason: The stream holds data up to 1 month then records are removed by Shopify.
- name: balance_transactions
bypass_reason: The stream requires real purchases to fill in the data.
- name: customer_saved_search
bypass_reason: The stream is not available for our sandbox.
- name: disputes
bypass_reason: The stream requires real purchases to fill in the data.
incremental:
Expand All @@ -76,9 +76,6 @@ acceptance_tests:
bypass_reason: May contain dynamically changed URL params
- name: images/*/updated_at
bypass_reason: Value can change as the account data is not frozen
products_graph_ql:
- name: onlineStorePreviewUrl
bypass_reason: Floating URL values
product_variants:
- name: updated_at
bypass_reason: Value can change as the account data is not frozen
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9329,137 +9329,6 @@
"source_defined_primary_key": [["id"]],
"is_resumable": true
},
{
"name": "products_graph_ql",
"json_schema": {
"$schema": "http://json-schema.org/schema#",
"properties": {
"createdAt": {
"description": "The date and time when the product was created.",
"type": "string"
},
"description": {
"description": "The product's description.",
"type": "string"
},
"descriptionHtml": {
"description": "The product's description in HTML format.",
"type": "string"
},
"handle": {
"description": "The unique URL-friendly handle of the product.",
"type": "string"
},
"id": {
"description": "The unique identifier of the product.",
"type": "string"
},
"isGiftCard": {
"description": "Indicates whether the product is a gift card.",
"type": "boolean"
},
"legacyResourceId": {
"description": "The legacy resource ID of the product.",
"type": "string"
},
"mediaCount": {
"description": "The total count of media (images/videos) associated with the product.",
"type": "integer"
},
"onlineStorePreviewUrl": {
"description": "The URL for previewing the product on the online store.",
"type": "string"
},
"onlineStoreUrl": {
"description": "The URL of the product on the online store.",
"type": ["null", "string"]
},
"options": {
"description": "Represents various options available for the product",
"items": {
"properties": {
"id": {
"description": "The unique identifier of the option.",
"type": "string"
},
"name": {
"description": "The name of the option.",
"type": "string"
},
"position": {
"description": "The position of the option.",
"type": "integer"
},
"values": {
"description": "Contains the different values for the options",
"items": {
"description": "The possible values for the option.",
"type": "string"
},
"type": "array"
}
},
"type": "object"
},
"type": "array"
},
"productType": {
"description": "The type or category of the product.",
"type": "string"
},
"publishedAt": {
"description": "The date and time when the product was published.",
"type": ["null", "string"]
},
"shop_url": {
"description": "The URL of the shop where the product is listed.",
"type": "string"
},
"status": {
"description": "The status of the product.",
"type": "string"
},
"tags": {
"description": "Contains tags associated with the product",
"items": {
"description": "The tags associated with the product.",
"type": "string"
},
"type": "array"
},
"title": {
"description": "The title or name of the product.",
"type": "string"
},
"totalInventory": {
"description": "The total inventory count of the product.",
"type": "integer"
},
"totalVariants": {
"description": "The total number of variants available for the product.",
"type": "integer"
},
"tracksInventory": {
"description": "Indicates whether inventory tracking is enabled for the product.",
"type": "boolean"
},
"updatedAt": {
"description": "The date and time when the product was last updated.",
"type": "string"
},
"vendor": {
"description": "The vendor or manufacturer of the product.",
"type": "string"
}
},
"type": "object"
},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updatedAt"],
"source_defined_primary_key": [["id"]],
"is_resumable": true
},
{
"name": "product_variants",
"json_schema": {
Expand Down Expand Up @@ -10397,46 +10266,6 @@
"source_defined_primary_key": [["id"]],
"is_resumable": true
},
{
"name": "customer_saved_search",
"json_schema": {
"type": ["null", "object"],
"additionalProperties": true,
"properties": {
"created_at": {
"description": "The date and time when the customer saved search was created.",
"type": ["null", "string"],
"format": "date-time"
},
"id": {
"description": "The unique identifier for the customer saved search.",
"type": ["null", "integer"]
},
"name": {
"description": "The name given to the customer saved search.",
"type": ["null", "string"]
},
"query": {
"description": "The search query string or parameters used for this saved search.",
"type": ["null", "string"]
},
"shop_url": {
"description": "The URL of the shop associated with this customer saved search.",
"type": ["null", "string"]
},
"updated_at": {
"description": "The date and time when the customer saved search was last updated.",
"type": ["null", "string"],
"format": "date-time"
}
}
},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["id"],
"source_defined_primary_key": [["id"]],
"is_resumable": true
},
{
"name": "customer_address",
"json_schema": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@
"name": "products",
"relations": {}
},
{
"name": "products_graph_ql",
"relations": {}
},
{
"name": "product_variants",
"relations": {
Expand Down Expand Up @@ -264,10 +260,6 @@
"location_id": "locations.id"
}
},
{
"name": "customer_saved_search",
"relations": {}
},
{
"name": "customer_address",
"relations": {
Expand Down
34 changes: 0 additions & 34 deletions airbyte-integrations/connectors/source-shopify/erd/source.dbml
Original file line number Diff line number Diff line change
Expand Up @@ -825,31 +825,6 @@ Table "products" {
"feedback" object
}

Table "products_graph_ql" {
"createdAt" string
"description" string
"descriptionHtml" string
"handle" string
"id" string [pk]
"isGiftCard" boolean
"legacyResourceId" string
"mediaCount" integer
"onlineStorePreviewUrl" string
"onlineStoreUrl" string
"options" array
"productType" string
"publishedAt" string
"shop_url" string
"status" string
"tags" array
"title" string
"totalInventory" integer
"totalVariants" integer
"tracksInventory" boolean
"updatedAt" string
"vendor" string
}

Table "product_variants" {
"id" integer [pk]
"product_id" integer
Expand Down Expand Up @@ -1008,15 +983,6 @@ Table "transactions" {
"shop_url" string
}

Table "customer_saved_search" {
"created_at" string
"id" integer [pk]
"name" string
"query" string
"shop_url" string
"updated_at" string
}

Table "customer_address" {
"address1" string
"address2" string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,6 @@
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"updatedAt": "2027-07-11T13:07:45-07:00"
},
"stream_descriptor": {
"name": "products_graph_ql"
}
}
},
{
"type": "STREAM",
"stream": {
Expand Down Expand Up @@ -594,17 +583,6 @@
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"updated_at": "2027-07-11T13:07:45-07:00"
},
"stream_descriptor": {
"name": "customer_saved_search"
}
}
},
{
"type": "STREAM",
"stream": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,6 @@
"cursor_field": ["updated_at"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "products_graph_ql",
"json_schema": {},
"supported_sync_modes": ["incremental", "full_refresh"],
"source_defined_cursor": true,
"default_cursor_field": ["updatedAt"]
},
"sync_mode": "incremental",
"cursor_field": ["updatedAt"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "metafield_products",
Expand Down Expand Up @@ -526,18 +514,6 @@
"cursor_field": ["id"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "customer_saved_search",
"json_schema": {},
"supported_sync_modes": ["incremental", "full_refresh"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"]
},
"sync_mode": "incremental",
"cursor_field": ["updated_at"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "customer_address",
Expand Down
Loading
Loading