[Load CDK] test improvements #50406
Merged
[Load CDK] test improvements #50406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
edgao
commented
Dec 24, 2024
| val stream = | ||
| DestinationStream( | ||
| DestinationStream.Descriptor(randomizedNamespace, "problematic_types"), | ||
| Append, | ||
| ObjectType( | ||
| linkedMapOf( | ||
| "id" to | ||
| "id" to intType, |
There was a problem hiding this comment.
adding an explicit id field helps RecordDiffer generate a nicer diff (i.e. instead of saying "there was an extra record, and also a missing record", it'll be able to match the records together + diff their fields)
edgao
force-pushed
the
edgao/iceberg_timestamp_fix
branch
from
0e479de to
797e691
Compare
edgao
force-pushed
the
edgao/avro_parquet_data_dumping_without_coercion
branch
from
44f9a6d to
2af3dc8
Compare
edgao
force-pushed
the
edgao/avro_parquet_data_dumping_without_coercion
branch
from
2af3dc8 to
1d3fe56
Compare
johnny-schmidt
approved these changes
Jan 2, 2025
edgao
force-pushed
the
edgao/avro_parquet_data_dumping_without_coercion
branch
from
1d3fe56 to
6b4d481
Compare
edgao
commented
Jan 3, 2025
| @@ -37,6 +37,9 @@ dependencies { | |||
| // temporary dependencies so that we can continue running the legacy test suite. | |||
| // eventually we should remove those tests + rely solely on the bulk CDK tests. | |||
| integrationTestLegacyImplementation testFixtures(project(":airbyte-cdk:java:airbyte-cdk:airbyte-cdk-s3-destinations")) | |||
|
|
|||
| // TODO this should come from from the cdk plugin + respect the cdk version | |||
| integrationTestImplementation testFixtures(project(":airbyte-cdk:bulk:toolkits:bulk-cdk-toolkit-load-avro")) | |||
There was a problem hiding this comment.
fyi - submitted https://github.com/airbytehq/airbyte-internal-issues/issues/11245 + assigned it to myself, I want to knock this out before I forget, but don't want to block this PR on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/11218, closes https://github.com/airbytehq/airbyte-internal-issues/issues/11221
as usual, just look at each commit individually:
FailOnAllUnknownTypesExceptNullmapper, and it's also doing this