✨ Source Azure Blob Storage: add client_credentials auth #50398
+177
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vpipkt is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
the
area/documentation
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
vpipkt
force-pushed
the
feat/az-blob-client-cred
branch
from
e17c87a to
bf1fae5
Compare
vpipkt
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
vpipkt
changed the title
vpipkt
changed the title
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
marcosmarxm
requested changes
Dec 23, 2024
| @@ -12,7 +12,7 @@ data: | |||
| connectorSubtype: file | |||
| connectorType: source | |||
| definitionId: fdaaba68-4875-4ed9-8fcd-4ae1e0a25093 | |||
| dockerImageTag: 0.4.4 | |||
| dockerImageTag: 0.5.4 | |||
There was a problem hiding this comment.
Suggested change
| dockerImageTag: 0.5.4 | |
| dockerImageTag: 0.5.0 |
Please bump to 0.5.0 version.
In user acceptance test, we see wierd behaviour with it acting as if its doing Oauth2 advanced config
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
vpipkt
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
/format-fix
|
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In connector
source-azure-blob-storage, allow authentication to Azure usingclient_credentialstype of grant. This is a common pattern for accessing Azure resources using a Service Principal's app registration.How
Add a third option to the authentication for using only tenant id, client id and client secret; Add a new Authenticator inheriting the Oauth2Authenticator that sets options specific to Azure's requirements found here.
Review guide
stream_reader.pyadd another Authenticator class and wire it up to specunit_tests0.
test_config_migration: use a temp file so test execution doesn't overwrite files in git4. add a simple test for new Authenticator
User Impact
Adds a new option to authenticate using Service Principals. Should not impact existing authentication patterns
Can this PR be safely reverted and rolled back?