-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for custom image registries #49137
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
In a separate task I'm reviewing the deployment docs and may end of merging/repurposing OSS and enterprise. For now this information appears twice. It's not meant to be this way permanently. |
Thanks Alex. This feedback was really good. I mostly used the structure you proposed, but I realized I could tuck the auth portion within the first heading reasonably well, so I did that and kept the process to two main steps. Hopefully that makes sense to people. I tested the overall flow and have the images in my GitHub account (thanks for the command you provided).
I don't consider this a blocker, but I was never able to get this part to work. I'm probably doing it wrong though. |
These docs are awesome. Left a couple nits, then good to merge. |
What
Deployment docs for custom image registries.
How
Adds a new topic to the OSS deployment guide, and a new section to the enterprise deployment guide. These sections are mostly the same, and provide guidance on how to modify your values.yaml file and push images to your registry.
Review guide
User Impact
People now have instructions to set up custom registries for their images.
Can this PR be safely reverted and rolled back?