Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update the airbyte cdk version for milvus #48823

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frankiebromage
Copy link

@frankiebromage frankiebromage commented Dec 5, 2024

What

  • Bringing the Milvus Destination of the airbyte cdk up to date in preparation for adding of this feature upgrade #91

How

  • Bumped the airbyte-cdk version in the pyproject.toml file and made change to pydantic import because pydantic version has increased

Review guide

User Impact

  • No user impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:00pm

Copy link

vercel bot commented Dec 5, 2024

Someone is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aaronsteers
❌ Frankie Bromage


Frankie Bromage seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -16,9 +16,13 @@ repository = "https://github.com/airbytehq/airbyte"
[[tool.poetry.packages]]
include = "destination_milvus"

[tool.poetry.dependencies.airbyte-cdk]
# Version cnstrained by PyAirbyte (`airbyte`) version
version = ">=1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we try to take the latest CDK version here?

Suggested change
version = ">=1.0"
version = "^6.9.0"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have updated the CDK version and had to update the python version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants