Airbyte-ci: Remove gradle task `connectorAcceptanceTest` #30326

bnchrch · 2023-09-11T21:58:11Z

What

We no longer need or support running the connectorAcceptanceTest gradle task to run CAT tests.

And having this test around is causing failures in some connector test builds

(closes #30306)
(blocked by #30461

How

So lets remove it

Removes connectorAcceptanceTest as a gradle command
Removes airbyte-connector-acceptance-test plugin from all gradle files
Remove -x connectorAcceptanceTest from airbyte-ci

github-actions · 2023-09-11T21:58:39Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

bnchrch · 2023-09-11T22:01:23Z

Cancelled connectors test (too many)

Started new test on subset

--name=destination-bigquery --name=source-chargebee --name=source-postgres --name=destination-postgres

https://github.com/airbytehq/airbyte/actions/runs/6152201971

github-actions · 2023-09-11T22:19:38Z

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage	70.56%	🍏

bnchrch · 2023-09-12T01:47:14Z

Running legacy test for source-mysql: https://github.com/airbytehq/airbyte/actions/runs/6153885185

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6153885185
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6153885185
🐛 https://gradle.com/s/3qt6ah2yi7sas

Build Failed

Test summary info:

Could not find result summary

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/6154180248
❌ source-mysql https://github.com/airbytehq/airbyte/actions/runs/6154180248
🐛 https://gradle.com/s/33kfgvm4diudc

Build Failed

Test summary info:

Could not find result summary

Running legacy test on master

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164253329
❌ source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164253329
🐛

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164344467
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164344467
🐛

Build Failed

Test summary info:

Could not find result summary

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164471959
❌ source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164471959
🐛

Build Failed

Test summary info:

Could not find result summary

bnchrch · 2023-09-12T01:50:11Z

Run regular test for destination-redshift and destination-snowflake: https://github.com/airbytehq/airbyte/actions/runs/6154196448

bnchrch · 2023-09-12T20:50:52Z

/legacy-test connector="connectors/source-mysql"

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164724615
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164724615
🐛 https://gradle.com/s/ppgzeatqgqits

Build Failed

Test summary info:

Could not find result summary

bnchrch · 2023-09-12T21:15:29Z

/legacy-test connector="connectors/source-mysql"

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164947833
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6164947833
🐛

Build Failed

Test summary info:

Could not find result summary

bnchrch · 2023-09-13T01:35:30Z

/legacy-test connector="connectors/source-mysql"

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6166860209
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6166860209
No Python unittests run

Build Passed

Test summary info:

All Passed

bnchrch · 2023-09-14T00:55:02Z

/legacy-test connector="connectors/source-mysql"

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6179548664
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6179548664
🐛 https://gradle.com/s/3kj43hy5jkwxo

Build Failed

Test summary info:

Could not find result summary

postamar

LGTM! Kill it with fire.

By the way, the script tools/bin/ci_integration_test.sh calls gradle with the integrationTest target and expects to run the acceptance tests. To this end it sets properties on the command line like -PconnectorAcceptanceTest.useLocalCdk=. Can you get rid of these please? FYI this script is what's called in the legacy-test-command.yml workflow.

bnchrch · 2023-09-14T23:00:14Z

@postamar I wanted to merge this bad, but unfortunately right now we cant as the cdk team uses legacy test to test out there changes...

Were going to update the airbyte-ci test command to use the local cdk via a flag to solve this. Then we can merge this PR in

This reverts commit 977125a.

This reverts commit 70f897c.

…ceTest

bnchrch · 2023-09-19T19:33:18Z

/legacy-test connector="connectors/source-mysql"

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6240116394
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/6240116394
No Python unittests run

Build Passed

Test summary info:

All Passed

bnchrch · 2023-09-19T20:15:59Z

/approve-and-merge reason="format failure on master, and failure of source-postgres qa check on master, unrelated, will deal with separately"

octavia-approvington · 2023-09-19T20:16:34Z

It's time

bnchrch requested review from a team September 11, 2023 21:58

bnchrch requested a review from a team as a code owner September 11, 2023 21:58

octavia-squidington-iii added the area/connectors Connector related issues label Sep 11, 2023

bnchrch added the checklist-action-run label Sep 11, 2023

bnchrch force-pushed the bnchrch/ci/remove-gradle-connectorAcceptanceTest branch from 14065ea to 977125a Compare September 12, 2023 21:14

bnchrch force-pushed the bnchrch/ci/remove-gradle-connectorAcceptanceTest branch from e9577f1 to c037267 Compare September 14, 2023 00:54

postamar approved these changes Sep 14, 2023

View reviewed changes

bnchrch mentioned this pull request Sep 15, 2023

Airbyte-ci: Add local cdk support #30461

Merged

bnchrch added 5 commits September 14, 2023 19:07

Remove airbyte-connector-acceptance-test from build.gradle

62f8842

Delete acceptance test gradle file

2c1fc99

Remove local cdk

05b206a

Revert "Remove local cdk"

70f897c

This reverts commit 977125a.

Revert "Revert "Remove local cdk""

fdb0d58

This reverts commit 70f897c.

bnchrch force-pushed the bnchrch/ci/remove-gradle-connectorAcceptanceTest branch from c037267 to fdb0d58 Compare September 15, 2023 02:08

Remove local-cdk script

b5a3f2b

rodireich approved these changes Sep 15, 2023

View reviewed changes

Merge branch 'master' into bnchrch/ci/remove-gradle-connectorAcceptan…

d0801ee

…ceTest

octavia-approvington approved these changes Sep 19, 2023

View reviewed changes

octavia-approvington merged commit 5c56ac1 into master Sep 19, 2023
15 of 19 checks passed

octavia-approvington deleted the bnchrch/ci/remove-gradle-connectorAcceptanceTest branch September 19, 2023 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Airbyte-ci: Remove gradle task `connectorAcceptanceTest` #30326

Airbyte-ci: Remove gradle task `connectorAcceptanceTest` #30326

bnchrch commented Sep 11, 2023 •

edited

Loading

github-actions bot commented Sep 11, 2023 •

edited by bnchrch

Loading

bnchrch commented Sep 11, 2023

github-actions bot commented Sep 11, 2023 •

edited

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 12, 2023 •

edited

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 13, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 14, 2023 •

edited by github-actions bot

Loading

postamar left a comment •

edited

Loading

bnchrch commented Sep 14, 2023

bnchrch commented Sep 19, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 19, 2023

octavia-approvington commented Sep 19, 2023

Airbyte-ci: Remove gradle task connectorAcceptanceTest #30326

Airbyte-ci: Remove gradle task connectorAcceptanceTest #30326

Conversation

bnchrch commented Sep 11, 2023 • edited Loading

What

How

github-actions bot commented Sep 11, 2023 • edited by bnchrch Loading

Before Merging a Connector Pull Request

bnchrch commented Sep 11, 2023

github-actions bot commented Sep 11, 2023 • edited Loading

Coverage report for source-postgres

bnchrch commented Sep 12, 2023 • edited by github-actions bot Loading

Build Failed

Build Failed

Build Failed

Build Failed

Build Failed

bnchrch commented Sep 12, 2023 • edited Loading

bnchrch commented Sep 12, 2023 • edited by github-actions bot Loading

Build Failed

bnchrch commented Sep 12, 2023 • edited by github-actions bot Loading

Build Failed

bnchrch commented Sep 13, 2023 • edited by github-actions bot Loading

Build Passed

bnchrch commented Sep 14, 2023 • edited by github-actions bot Loading

Build Failed

postamar left a comment • edited Loading

Choose a reason for hiding this comment

bnchrch commented Sep 14, 2023

bnchrch commented Sep 19, 2023 • edited by github-actions bot Loading

Build Passed

bnchrch commented Sep 19, 2023

octavia-approvington commented Sep 19, 2023

Airbyte-ci: Remove gradle task `connectorAcceptanceTest` #30326

Airbyte-ci: Remove gradle task `connectorAcceptanceTest` #30326

bnchrch commented Sep 11, 2023 •

edited

Loading

github-actions bot commented Sep 11, 2023 •

edited by bnchrch

Loading

github-actions bot commented Sep 11, 2023 •

edited

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 12, 2023 •

edited

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 12, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 13, 2023 •

edited by github-actions bot

Loading

bnchrch commented Sep 14, 2023 •

edited by github-actions bot

Loading

postamar left a comment •

edited

Loading

bnchrch commented Sep 19, 2023 •

edited by github-actions bot

Loading