fix: (source-shopify) - deprecate an old ProductGraphQL and CustomerSavedSearch streams from the stream catalog
#51037
+224
−30,046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazarnov
added
connectors/source/shopify
breaking-change
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
maxi297
reviewed
Jan 10, 2025
There was a problem hiding this comment.
LGTM! Just a couple of small comments. Let's wait for @katmarkham to review this
tybernstein
reviewed
Jan 10, 2025
…ify/deprecate-products-graph-ql-stream
tybernstein
previously approved these changes
Jan 10, 2025
tybernstein
reviewed
Jan 10, 2025
tybernstein
dismissed
their stale review
Meant to only approve migration guide, code review still needed
…ify/deprecate-products-graph-ql-stream
katmarkham
requested changes
Jan 12, 2025
| - `Products Graph QL` | ||
| - `Customer Saved Search` | ||
|
|
||
| To replace the old `Products Graph QL` use the `Products` instead. |
There was a problem hiding this comment.
don't we have a chart somewhere for this type of change?
There was a problem hiding this comment.
Not sure I'm aware of any at the moment. I'd appreciate sharing one.
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Original Slack thread: https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1736286359890149
We would need to deprecate the
ProductGraphQLandCustomerSavedSearchstreams completely, since these are using the old deprecatedapi version(2023-07 and 2022-01 respectively) which are not supported anymore. Moreover, Shopify demands us to stop making API calls using these API versions and move to the2024-04at least, which we effectively do by far for all other streams.How
ProductGraphQLstream from the sourceCustomerSavedSearchstream from the sourceUser Impact
This is considered as
Breaking change:ProductsGraphQLstream - use theProductsstream instead (it covers all the fields of an old deprecated stream)CustomerSaverSearchthere is no alternative at the moment, but there is a chance to re-implement this stream again usingGraphQL BULK, once there is a demand from the Customer perspectiveCan this PR be safely reverted and rolled back?