Skip to content

Commit

Permalink
Increase method visibility level for Teradata. (#49858)
Browse files Browse the repository at this point in the history
Increase the visibility on these functions to unblock Teradata's current implementation.
  • Loading branch information
davinchia authored Dec 24, 2024
1 parent a99bc69 commit 408261f
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion airbyte-cdk/java/airbyte-cdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ corresponds to that version.

| Version | Date | Pull Request | Subject |
|:-----------|:-----------|:------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 0.48.1 | 2024-11-13 | [\#48482](https://github.com/airbytehq/airbyte/pull/48482) | Adding support converting very large numbers via BigInteger l |
| 0.48.3 | 2024-12-23 | [\#49858](https://github.com/airbytehq/airbyte/pull/49858) | Relax various Destination CDK methods visibility. |
| 0.48.1 | 2024-11-13 | [\#48482](https://github.com/airbytehq/airbyte/pull/48482) | Adding support converting very large numbers via BigInteger |
| 0.48.0 | 2024-10-23 | [\#46302](https://github.com/airbytehq/airbyte/pull/46302) | Add support for file transfer |
| 0.47.3 | 2024-10-23 | [\#46689](https://github.com/airbytehq/airbyte/pull/46689) | Split DestinationAcceptanceTest |
| 0.47.2 | 2024-10-21 | [\#47216](https://github.com/airbytehq/airbyte/pull/47216) | improve java compatibiilty |
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=0.48.2
version=0.48.3
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ abstract class JdbcDestinationHandler<DestinationState>(
): ResultSet = dbmetadata.getTables(catalogName, id.rawNamespace, id.rawName + suffix, null)

@Throws(Exception::class)
private fun isFinalTableEmpty(id: StreamId): Boolean {
protected open fun isFinalTableEmpty(id: StreamId): Boolean {
return !jdbcDatabase.queryBoolean(
dslContext
.select(
Expand Down Expand Up @@ -211,7 +211,8 @@ abstract class JdbcDestinationHandler<DestinationState>(
}

@Throws(SQLException::class)
protected fun getAllDestinationStates(): Map<AirbyteStreamNameNamespacePair, DestinationState> {
protected open fun getAllDestinationStates():
Map<AirbyteStreamNameNamespacePair, DestinationState> {
try {
// Guarantee the table exists.
jdbcDatabase.execute(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ constructor(
.columns(buildFinalTableFields(columns, metaFields))
}

private fun insertAndDeleteTransaction(
protected open fun insertAndDeleteTransaction(
streamConfig: StreamConfig,
finalSuffix: String?,
minRawTimestamp: Optional<Instant>,
Expand Down Expand Up @@ -507,7 +507,7 @@ constructor(
return createSchemaSql.sql
}

protected fun createTableSql(
protected open fun createTableSql(
namespace: String,
tableName: String,
columns: LinkedHashMap<ColumnId, AirbyteType>
Expand Down

0 comments on commit 408261f

Please sign in to comment.