fix: update ingress template value for < 1.19-0 #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpdeethree can you chec this contribution? |
|
|
@marcosmarxm i think this got lost in the mix, if you want to route it back through the process |
Thanks for bumping this! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The original service name for
semverCompare "<1.19-0", which isis not the correct name of the service. Instead, it should be
This is the current value for
semverCompare ">=1.19-0".Strangely, the
ifpart was updated in a previous PR, but the same change was not made in theelsepart (see the image below). This PR rectifies this discrepancy.How
The
serviceName(forsemverCompare "<1.19-0") was changed from{{ $fullName }}-svcto{{ $.Release.Name }}-airbyte-webapp-svc.Can this PR be safely reverted / rolled back?
🚨 User Impact 🚨
There are no breaking changes. The user (of this version) currently cannot access the UI. After this is merged, the user will be able to access the UI again.