Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingress object for exposing airbyte-api-server #275

Closed
wants to merge 4 commits into from
Closed

Add ingress object for exposing airbyte-api-server #275

wants to merge 4 commits into from

Conversation

larrywax
Copy link
Contributor

@larrywax larrywax commented Sep 18, 2023 •
edited
Loading

What

This PR adds an ingress object to the airbyte-api-server chart in order to expose the API outside of the kubernetes cluster

How

Add helm template for ingress object

Can this PR be safely reverted / rolled back?

  • YES 💚
  • NO ❌

🚨 User Impact 🚨

If the user enables and configures the ingress, an ingress object will be created

@larrywax
Copy link
Contributor Author

larrywax commented Oct 3, 2023

Can someone have a look a this PR? 🙏
We had to fork the official helm chart because we really need to expose Airbyte APIs outside of our k8s cluster, but I would love to switch back to the official one as soon as possible

@oleksandr-gubchenko
Copy link

any updates?

@marcosmarxm marcosmarxm requested a review from c-p-b October 19, 2023 13:30
@marcosmarxm
Copy link
Member

@cpdeethree can you take a look?

@damjan-trickovik-deel
Copy link

damjan-trickovik-deel commented Oct 19, 2023 •
edited
Loading

larrywax
Are you using the OSS version of Airbyte?

@larrywax
Copy link
Contributor Author

larrywax Are you using the OSS version of Airbyte?

Yes, we do, but we plan to move to enterprise at some point

c-p-b
c-p-b approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@c-p-b c-p-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@c-p-b
Copy link
Contributor

c-p-b commented Oct 23, 2023

This was merged and released as part of 73eaf48

Thanks for your contribution!

@c-p-b c-p-b closed this Oct 23, 2023
@pdemagny pdemagny mentioned this pull request Mar 21, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-p-b c-p-b c-p-b approved these changes

Assignees
No one assigned
Labels
area/platform kubernetes needs-triage team/application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@larrywax @oleksandr-gubchenko @marcosmarxm @damjan-trickovik-deel @c-p-b @octavia-squidington-iii