-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't include all of lodash #1847
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the improvement here @RobinClowers ! 🙌 had a quick comment on the non-root lock files.
8608590
to
95ac4ff
Compare
@williaster can we get this merged please? Let me know if there is anything else outstanding. |
@RobinClowers have you considered replacing lodash entirely with https://es-toolkit.slash.page/? It should be faster and smaller while being more or less a drop in replacement for lodash functions. |
@VIKTORVAV99 I hadn't heard of es toolkit, looks like an awesome project! Since many of these projects only depend on one or two functions, I'm not sure the savings would be significant (compared to all of lodash). Also, there might be subtle differences in the behavior between the libraries. That said, it sounds like a good improvement, but I'm not personally motivated to make the change. Especially since this low risk PR hasn't been merged, I worry that it would be wasted effort. |
Oh, one other concern, I didn't know what the browser support policy is for visx, it might not be safe to depend on modern is for this project. For my project it would be, but again I haven't looked closely at the browser support guarantees visx provides. |
💥 Breaking Changes
🚀 Enhancements
visx-responsive
,visx-text
, andvisx-xychart
.📝 Documentation
🐛 Bug Fix
🏠 Internal