Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain unbounded dimensions when exactly one dimension is unbounded #2437

Merged
merged 9 commits into from
Dec 29, 2023

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Dec 29, 2023

Fixes #2264

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal changed the title Use aspect ratio for LottieAnimation sizing Constrain unbounded dimensions when exactly one dimension is unbounded Dec 29, 2023
@gpeal gpeal marked this pull request as ready for review December 29, 2023 20:35
Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit a6e416d into master Dec 29, 2023
6 checks passed
@gpeal gpeal deleted the gpeal/aspect-ratio branch December 29, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height not calculated based on screen width in Jetpack Compose
1 participant