Implement compatible version negotiation #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5047 5092 +45
=========================================
+ Hits 5047 5092 +45 ☔ View full report in Codecov by Sentry. |
jlaine
force-pushed
the
compatible-version-neg
branch
4 times, most recently
from
9bb0b38 to
da213ab
Compare
A QUIC server must not accept a Version Information transport parameter whose chosen version is not included in the available versions.
We currently try to find the right moment to parse transport parameters inside the CRYPTO frame handler. Instead, we can rely on a clearer signal from the TLS engine: the remote party's TLS extensions become available at the same time as ALPN negotiation completes. This will become needed to implement compatible version negotiation, since we need to determine the negotiated version *before* updating the traffic keys.
jlaine
force-pushed
the
compatible-version-neg
branch
from
da213ab to
a488d21
Compare
Enable compatible version negotiation according to RFC 9368. Unlike incompatible negotiation which uses a Version Negotiation packet, this allows a switch between compatible versions without an additional roundtrip. As an example we support switching between version 1 (RFC 9000) and version 2 (RFC 9369) and vice versa. On the server side we honour the client's preferences.
jlaine
force-pushed
the
compatible-version-neg
branch
from
a488d21 to
bfb070f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.