Rework version negotiation, add support for Version Information #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the code for handling retry and version negotiation to their own methods to simplify `receive_datagram`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5018 5047 +29
=========================================
+ Hits 5018 5047 +29 ☔ View full report in Codecov by Sentry. |
This parameter is defined in RFC 9368 and is used for compatible version negotiation. We also ensure that if parsing a parameter results in a shorter read than the parameter's length, we raise a `ValueError` not an `AssertionError`.
jlaine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.