-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Python 3.12 #942
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
thanks a stack for conceiving and maintaining the excellent yarl package. We have been tripped by missing support for Python 3.12 at daq-tools/influxio#57. May we humbly ask if you have the capacity to bring in this patch, or, alternatively, if you would accept any kind of support on this matter? Keep up the spirit, and with kind regards, |
The linter checks seem to be failing upstream in |
Yep, I'll fix that. Could you use the rebase button next time? |
@amotl this PR only modifies some metadata. The runtime support is already present on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I'd add a separate change note 942.contrib.rst
to notify the contributors about requiring Python 3.12 CI jobs to pass in pull requests.
CHANGES/942.misc.rst
Outdated
@@ -0,0 +1 @@ | |||
Official support for Python 3.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We write (most of the) individual change note fragments in the past tense, because they're targeted at the end-users and don't necessarily contain information about internal implementation details or decision.
Changelog is supposed to describe what changed compared to the previous version.
Individual fragments should have the same style. When looking at individual PRs on GitHub, it's unobvious and is hard to judge whether it “fits”.
However, we have RTD PR builds enabled, so it's possible to preview at https://yarl--942.org.readthedocs.build/en/942/changes.html whether a fragment contributes to the changelog being cohesive.
I think, this phrase can be rephrased to describe more accurately what the PR does, with the end-users being the target audience in mind.
Official support for Python 3.12. | |
Declared Python 3.12 supported officially in the distribution package metadata | |
-- by :user:`edgarrmondragon`. |
CHANGES/942.misc.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the below note in mind, I'd change this fragment type from misc
to packaging
. I recently added more clear categories for the Towncrier fragments that should reflect the changelog sections better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done in 810c06e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, PSF Chronographer / Timeline protection
is complaining now:
No files matching re.compile('news/(?P<issue_number>[^\\./]+)\.(?P<fragment_type>feature|bugfix|doc|removal|misc)(\.\d+)?(\.[^\\./]+)*$') pattern added
https://github.com/aio-libs/yarl/pull/942/checks?check_run_id=18803866754
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch.. Looks like I need to teach the bot about an extra config file. Totally not your fault. I'll force-merge if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I can help in any way 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. When I first wrote that code, I didn't know that an alternative config path fallback exists. Though, it's no big deal. I'll correct it and redeploy later.
So it looks like that contrib file is still needed.. |
Hi again, thank you so much for concluding this patch and running a release. This downstream patch demonstrates it works well. Keep up the spirit, and with kind regards, |
What do these changes do?
Communicates official support for Python 3.12
Are there changes in behavior for the user?
No
Related issue number
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.