add / to protected chars in _QUERY_REQUOTER

[SafaSafari]

What do these changes do?

this patch will fix query reqouter skip chars

Are there changes in behavior for the user?

who users cannot download Instagram posts using aiohttp, after this patch will can =))

Related issue number

actually no, but I'm wondering why it's not =))

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> (e.g. 588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the PR
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa4091f) 99.74% compared to head (e505ecb) 99.74%.
Report is 15 commits behind head on master.

❗ Current head e505ecb differs from pull request most recent head 902ae06. Consider uploading reports for the commit 902ae06 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
=======================================
  Hits          770      770           
  Misses          2        2           

Flag	Coverage Δ
unit	99.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[webknjaz]

I would be curious to see a quote from the standard that this attempts to comply with, and some explanation of what doesn't work. With reproducers et al.

If this change is correct indeed, the PR will also need a test covering this specific case. And finally, the linting violations will have to be corrected.

Unfortunately, without understanding of what this patch attempts to fix and what the side effects would be, we can't accept this pull request in its current state.

@SafaSafari could you address the above shortcomings and provide us with all the information necessary to proceed?

[SafaSafari]

yarl1.mp4

this is what actually occurred and that's my fix for that

also i think linter failed to check because of ` character in CHANGES rst file
@webknjaz

[webknjaz]

also i think linter failed to check because of ` character in CHANGES rst file

A single backtick might. It corresponds to "any" role in Sphinx / RST. Which is why you must use double backticks to highlight inline code.

[webknjaz]

Use RST inline highlighting in the appropriate places. This also requires past tense and full sentences. The change notes are meant to show the end-users (the target audience) what the effect of the change is for them. Instagram is not something everyone puts in URLs. Something people would care about in a more generic way should be used.

[webknjaz]

The video doesn't show the actual URL original, nor can copy it. So it can't be verified.

Besides, the earlier points regarding the low quality and missing bits in the patch still stand.

But if I were to make a wild guess, you're probably hitting reencoding on redirects: aio-libs/aiohttp#5319 (comment). Using proper arguments (as in, requote_redirect_url=False) is the right way to solve this. Also, passing pre-built yarl objects to aiohttp can give more control for the initial input.
This is definitely not a bug. Not in yarl.

[webknjaz]

Closing per above.