-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanups to encode_url
#1405
Conversation
- Avoid useless assignments - Combine nested if statements
- Avoid useless assignments - Combine nested if statements
- Avoid useless assignments - Combine nested if statements
CodSpeed Performance ReportMerging #1405 will not alter performanceComparing Summary
|
1.32s call tests/test_url_benchmarks.py::test_human_repr Unrelated but |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
+ Coverage 96.05% 96.06% +0.01%
==========================================
Files 31 31
Lines 5748 5765 +17
Branches 343 344 +1
==========================================
+ Hits 5521 5538 +17
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raw_path
in the cache since we already have it along with coverage to make sure its set correctly