-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix round-trip of IPv6 addresses when converting to a string #1158
Conversation
The brackets were missing when the URL was convert to a string fixes #1157
I wonder if this is where we could finally stick a hypothesis-based property test.. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 95.46% 95.48% +0.01%
==========================================
Files 30 30
Lines 4807 4825 +18
Branches 428 429 +1
==========================================
+ Hits 4589 4607 +18
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It would be really nice to get #860 going. The open PRs list is shrinking enough that is coming to the top soon. |
What do these changes do?
The brackets were missing when the URL was convert to a string
fixes #1157
regressed in #1033
Are there changes in behavior for the user?
no