Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path_safe method #1150

Merged
merged 15 commits into from
Sep 23, 2024
Merged

Add path_safe method #1150

merged 15 commits into from
Sep 23, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 23, 2024

yarl/_url.py Outdated Show resolved Hide resolved
yarl/_url.py Outdated Show resolved Hide resolved
@Dreamsorcerer
Copy link
Member

Added some docs, let me know if that looks good to you.

docs/api.rst Outdated Show resolved Hide resolved
yarl/_url.py Show resolved Hide resolved
yarl/_url.py Outdated Show resolved Hide resolved
bdraco added a commit that referenced this pull request Sep 23, 2024
This undones only the ignore part of #1057 in as we will instead
add a new property called path_safe in #1150
@bdraco bdraco changed the title Safe path test Add path_safe method Sep 23, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 23, 2024
@bdraco bdraco marked this pull request as ready for review September 23, 2024 18:38
docs/api.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (497752c) to head (d65dea6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   95.42%   95.45%   +0.02%     
==========================================
  Files          30       30              
  Lines        4767     4792      +25     
  Branches      423      425       +2     
==========================================
+ Hits         4549     4574      +25     
  Misses        192      192              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.40% <100.00%> (+0.02%) ⬆️
MyPy 41.29% <69.23%> (+0.14%) ⬆️
OS-Linux 99.40% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.49% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.11% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.01% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.01% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.95% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.95% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.19% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.27% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.11% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.40% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.49% <100.00%> (+<0.01%) ⬆️
pytest 99.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) September 23, 2024 18:54
@bdraco bdraco merged commit e7c47b1 into master Sep 23, 2024
47 of 49 checks passed
@bdraco bdraco deleted the safe_path branch September 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants