Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py-spy sampling feature. #195

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Added py-spy sampling feature. #195

merged 4 commits into from
Jul 6, 2020

Conversation

everonegraham
Copy link
Contributor

@everonegraham everonegraham commented Jun 13, 2020

What do these changes do?

Adds the py-spy sampling feature to the project

Are there changes in behavior for the user?

make profile: tells py-spy to profile your running application for 60 seconds. It will generate a .svg in the root of the project directory. sampling duration can be modified by using the TIME variable. eg: make profile TIME=120

Related issue number

Issue #58

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it 58.enhancement
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

View rendered README.md

Fixed issue where cookiecutter.json file would generate in new projects even thou its not needed. I removed the cookiecutter.json file from `templates/{{cookiecutter.project_name}}` before buidling.
Implemented the use of py-spy to the project.
requirements-dev.txt Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Arfey
Copy link
Member

Arfey commented Jun 17, 2020

Please remove cookiecutter.json in ur pull request.

@Arfey
Copy link
Member

Arfey commented Jun 17, 2020

Could u add a svg file which was generated by profile command? 😀

@everonegraham
Copy link
Contributor Author

everonegraham commented Jun 19, 2020

Take a look at the .svg that was generated. Just need to download and open it in your favorite browser :)

Pull Request Edits
@Arfey
Copy link
Member

Arfey commented Jul 6, 2020

u have removed create_aio_app/template/{{cookiecutter.project_name}}/cookiecutter.json and create_aio_app/template/cookiecutter.json but last file need for generate project.

@everonegraham
Copy link
Contributor Author

Ah snap, my bad there. Let me get that sorted.

Re-added deleted cookiecutter.json
@Arfey Arfey merged commit 1af0eb5 into aio-libs:master Jul 6, 2020
@Arfey
Copy link
Member

Arfey commented Jul 6, 2020

Great, thx so m 😀

@webknjaz webknjaz linked an issue Sep 10, 2020 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add profiling for application
2 participants