Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] Restore FlowControlDataQueue class #9963

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 18, 2024

We no longer use FlowControlDataQueue internally as it was removed in #9793. It was assumed (incorrectly) it was not used externally. At least aiodocker uses it. There may be others so we will restore it for 3.11.

Please note that it will go away permanently in 4.x so its will probably be best to vendor the code in this PR if you will still need this class when 4.x is released.

fixes aio-libs/aiodocker#918

While we no longer use this internally, aiodocker uses it
see aio-libs/aiodocker#918
@bdraco bdraco added the backport:skip Skip backport bot label Nov 18, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (97be030) to head (af7fc1e).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9963   +/-   ##
=======================================
  Coverage   98.01%   98.02%           
=======================================
  Files         122      122           
  Lines       36796    36867   +71     
  Branches     4429     4438    +9     
=======================================
+ Hits        36067    36138   +71     
  Misses        545      545           
  Partials      184      184           
Flag Coverage Δ
CI-GHA 97.91% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.62% <100.00%> (+0.01%) ⬆️
OS-Windows 94.51% <100.00%> (+0.01%) ⬆️
OS-macOS 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.17% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.20% <100.00%> (+0.01%) ⬆️
Py-3.11.9 96.66% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.69% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.67% <100.00%> (+0.04%) ⬆️
Py-3.9.13 96.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.05% <100.00%> (-0.03%) ⬇️
Py-pypy7.3.16 96.65% <100.00%> (+<0.01%) ⬆️
VM-macos 96.72% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.62% <100.00%> (+0.01%) ⬆️
VM-windows 94.51% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #9963 will not alter performance

Comparing flow_control_data_queue_restore (af7fc1e) with 3.11 (97be030)

Summary

✅ 43 untouched benchmarks

@bdraco bdraco changed the title [3.11] Restore FlowControlDataQueue [3.11] Restore FlowControlDataQueue class Nov 18, 2024
@bdraco bdraco marked this pull request as ready for review November 18, 2024 23:47
@bdraco bdraco merged commit 902e7b2 into 3.11 Nov 18, 2024
36 of 37 checks passed
@bdraco bdraco deleted the flow_control_data_queue_restore branch November 18, 2024 23:54
@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

I should have done this for 3.12 as well as the timeline for dropping it will be 4.x

@bdraco bdraco added backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot and removed backport:skip Skip backport bot labels Nov 19, 2024
Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/902e7b244c04ba112067362a9f10515830326fa2/pr-9963

Backported as #9965

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

Thankfully it forward ports cleanly

bdraco pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant