-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] Restore FlowControlDataQueue
class
#9963
Conversation
While we no longer use this internally, aiodocker uses it see aio-libs/aiodocker#918
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9963 +/- ##
=======================================
Coverage 98.01% 98.02%
=======================================
Files 122 122
Lines 36796 36867 +71
Branches 4429 4438 +9
=======================================
+ Hits 36067 36138 +71
Misses 545 545
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9963 will not alter performanceComparing Summary
|
FlowControlDataQueue
class
I should have done this for 3.12 as well as the timeline for dropping it will be 4.x |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9965 🤖 @patchback |
fixes aio-libs/aiodocker#918 (cherry picked from commit 902e7b2)
Thankfully it forward ports cleanly |
…class (#9965) Co-authored-by: J. Nick Koston <[email protected]> fixes aio-libs/aiodocker#918
We no longer use
FlowControlDataQueue
internally as it was removed in #9793. It was assumed (incorrectly) it was not used externally. At leastaiodocker
uses it. There may be others so we will restore it for 3.11.Please note that it will go away permanently in 4.x so its will probably be best to vendor the code in this PR if you will still need this class when 4.x is released.
fixes aio-libs/aiodocker#918