Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for the URL dispatcher #9910

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 15, 2024

For checking #9907 impact

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9910 will not alter performance

Comparing url_dispatcher_benchmarks (3585ca7) with master (4441d3c)

Summary

✅ 26 untouched benchmarks

🆕 6 new benchmarks

Benchmarks breakdown

Benchmark master url_dispatcher_benchmarks Change
🆕 test_resolve_dynamic_resource_url_with_many_routes[pyloop] N/A 3.7 ms N/A
🆕 test_resolve_multiple_fixed_url_with_many_routes[pyloop] N/A 2.3 ms N/A
🆕 test_resolve_multiple_level_fixed_url_with_many_routes[pyloop] N/A 8.9 ms N/A
🆕 test_resolve_root_route[pyloop] N/A 929.8 µs N/A
🆕 test_resolve_single_fixed_url_with_many_routes[pyloop] N/A 940.2 µs N/A
🆕 test_resolve_static_root_route[pyloop] N/A 1.1 ms N/A

tests/test_benchmarks_web_urldispatcher.py Dismissed Show dismissed Hide dismissed
tests/test_benchmarks_web_urldispatcher.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (2249f2d) to head (3585ca7).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9910   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         119      120    +1     
  Lines       36385    36473   +88     
  Branches     4322     4342   +20     
=======================================
+ Hits        35917    36005   +88     
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.29% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.10% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.37% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.22% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.83% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.88% <100.00%> (+0.06%) ⬆️
Py-3.11.9 97.28% <100.00%> (+0.01%) ⬆️
Py-3.12.7 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.74% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.30% <100.00%> (+<0.01%) ⬆️
VM-macos 97.37% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.29% <100.00%> (+<0.01%) ⬆️
VM-windows 96.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 15, 2024 16:40
@bdraco bdraco enabled auto-merge (squash) November 15, 2024 16:40
@bdraco bdraco merged commit 4a9bbf9 into master Nov 15, 2024
39 of 40 checks passed
@bdraco bdraco deleted the url_dispatcher_benchmarks branch November 15, 2024 16:42
Copy link
Contributor

patchback bot commented Nov 15, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910

Backported as #9915

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2024
Copy link
Contributor

patchback bot commented Nov 15, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910

Backported as #9916

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2024
Copy link
Contributor

patchback bot commented Nov 15, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910

Backported as #9917

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants