Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump idna from 3.3 to 3.10 #9152

Open
wants to merge 2 commits into
base: 3.11
Choose a base branch
from
Open

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps idna from 3.3 to 3.10.

Release notes

Sourced from idna's releases.

v3.10

No release notes provided.

v3.9

No release notes provided.

v3.8

What's Changed

  • Fix regression where IDNAError exception was not being produced for certain inputs.
  • Add support for Python 3.13, drop support for Python 3.5 as it is no longer testable.
  • Documentation improvements
  • Updates to package testing using Github actions

Thanks to Hugo van Kemenade for contributions to this release.

Full Changelog: kjd/idna@v3.7...v3.8

v3.7

What's Changed

  • Fix issue where specially crafted inputs to encode() could take exceptionally long amount of time to process. [CVE-2024-3651]

Thanks to Guido Vranken for reporting the issue.

Full Changelog: kjd/idna@v3.6...v3.7

Changelog

Sourced from idna's changelog.

3.10 (2024-09-15) +++++++++++++++++

  • Reverted to Unicode 15.1.0 data. Unicode 16 has some significant changes to UTS46 processing that will require more work to properly implement.

3.9 (2024-09-13) ++++++++++++++++

  • Update to Unicode 16.0.0
  • Deprecate setup.cfg in favour of pyproject.toml
  • Use ruff for code formatting

Thanks to Waket Zheng for contributions to this release.

3.8 (2024-08-23) ++++++++++++++++

  • Fix regression where IDNAError exception was not being produced for certain inputs.
  • Add support for Python 3.13, drop support for Python 3.5 as it is no longer testable.
  • Documentation improvements
  • Updates to package testing using Github actions

Thanks to Hugo van Kemenade for contributions to this release.

3.7 (2024-04-11) ++++++++++++++++

  • Fix issue where specially crafted inputs to encode() could take exceptionally long amount of time to process. [CVE-2024-3651]

Thanks to Guido Vranken for reporting the issue.

3.6 (2023-11-25) ++++++++++++++++

  • Fix regression to include tests in source distribution.

3.5 (2023-11-24) ++++++++++++++++

  • Update to Unicode 15.1.0
  • String codec name is now "idna2008" as overriding the system codec "idna" was not working.
  • Fix typing error for codec encoding
  • "setup.cfg" has been added for this release due to some downstream lack of adherence to PEP 517. Should be removed in a future release so please prepare accordingly.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 16, 2024
@dependabot dependabot bot mentioned this pull request Sep 16, 2024
@github-actions github-actions bot enabled auto-merge (squash) September 16, 2024 11:27
@dependabot dependabot bot force-pushed the dependabot/pip/3.11/idna-3.10 branch from 2abfc63 to 932f5aa Compare September 16, 2024 12:10
Copy link

codecov bot commented Sep 16, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3378 1 3377 25
View the top 1 failed tests by shortest run time
tests.test_imports test_import_time
Stack Traces | 1.72s run time
pytester = &lt;Pytester PosixPath('.../pytest-of-runner/pytest-0/test_import_time0')&gt;

    @pytest.mark.internal
    @pytest.mark.skipif(
        not sys.platform.startswith("linux") or platform.python_implementation() == "PyPy",
        reason="Timing is more reliable on Linux",
    )
    def test_import_time(pytester: pytest.Pytester) -&gt; None:
        """Check that importing aiohttp doesn't take too long.
    
        Obviously, the time may vary on different machines and may need to be adjusted
        from time to time, but this should provide an early warning if something is
        added that significantly increases import time.
        """
        root = Path(__file__).parent.parent
        old_path = os.environ.get("PYTHONPATH")
        os.environ["PYTHONPATH"] = os.pathsep.join([str(root)] + sys.path)
    
        best_time_ms = 1000
        cmd = "import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000))"
        try:
            for _ in range(3):
                r = pytester.run(sys.executable, "-We", "-c", cmd)
    
                assert not r.stderr.str()
                runtime_ms = int(r.stdout.str())
                if runtime_ms &lt; best_time_ms:
                    best_time_ms = runtime_ms
        finally:
            if old_path is None:
                os.environ.pop("PYTHONPATH")
            else:
                os.environ["PYTHONPATH"] = old_path
    
        expected_time = _TARGET_TIMINGS_BY_PYTHON_VERSION.get(
            f"{sys.version_info.major}.{sys.version_info.minor}", 200
        )
&gt;       assert best_time_ms &lt; expected_time
E       assert 415 &lt; 250

_          = 2
best_time_ms = 415
cmd        = "import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000))"
expected_time = 250
old_path   = None
pytester   = &lt;Pytester PosixPath('.../pytest-of-runner/pytest-0/test_import_time0')&gt;
r          = &lt;RunResult ret=0 len(stdout.lines)=1 len(stderr.lines)=0 duration=0.56s&gt;
root       = PosixPath('.../work/aiohttp/aiohttp')
runtime_ms = 415

.../work/aiohttp/aiohttp/tests/test_imports.py:71: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@dependabot dependabot bot force-pushed the dependabot/pip/3.11/idna-3.10 branch from 932f5aa to 2d14243 Compare October 1, 2024 19:00
Bumps [idna](https://github.com/kjd/idna) from 3.3 to 3.10.
- [Release notes](https://github.com/kjd/idna/releases)
- [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
- [Commits](kjd/idna@v3.3...v3.10)

---
updated-dependencies:
- dependency-name: idna
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/3.11/idna-3.10 branch from 2d14243 to 08e6c59 Compare October 1, 2024 19:05
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #9152 will not alter performance

Comparing dependabot/pip/3.11/idna-3.10 (c68c9b0) with 3.11 (d4c0914)

Summary

✅ 14 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant