Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature new response property in ClientWebSocketResponse #8572

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

leszekhanusz
Copy link

@leszekhanusz leszekhanusz commented Aug 1, 2024

What do these changes do?

It is adding a new response public attribute to the ClientWebSocketResponse class.

It allows users to have access to response headers and cookies of a websocket request without needing to use the private _response attribute.

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No, this is quite straightforward.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (7ffb847) to head (ab3bd20).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8572      +/-   ##
==========================================
+ Coverage   97.68%   97.70%   +0.01%     
==========================================
  Files         107      107              
  Lines       33403    33429      +26     
  Branches     3923     3927       +4     
==========================================
+ Hits        32631    32663      +32     
+ Misses        559      555       -4     
+ Partials      213      211       -2     
Flag Coverage Δ
CI-GHA 97.61% <100.00%> (+0.01%) ⬆️
OS-Linux 97.27% <100.00%> (+0.02%) ⬆️
OS-Windows 95.64% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.94% <100.00%> (+0.02%) ⬆️
Py-3.10.11 97.08% <100.00%> (+0.01%) ⬆️
Py-3.10.14 97.02% <100.00%> (+0.02%) ⬆️
Py-3.11.9 97.25% <100.00%> (+0.02%) ⬆️
Py-3.12.4 97.38% <100.00%> (+0.01%) ⬆️
Py-3.8.10 95.40% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.91% <100.00%> (+0.02%) ⬆️
Py-3.9.13 97.07% <100.00%> (+0.02%) ⬆️
Py-3.9.19 97.02% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.16 96.59% <100.00%> (+0.02%) ⬆️
VM-macos 96.94% <100.00%> (+0.02%) ⬆️
VM-ubuntu 97.27% <100.00%> (+0.02%) ⬆️
VM-windows 95.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant