-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure websocket transport is closed when client does not close it #8200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8200 +/- ##
==========================================
+ Coverage 97.53% 97.56% +0.03%
==========================================
Files 107 107
Lines 32845 32936 +91
Branches 3851 3851
==========================================
+ Hits 32034 32133 +99
+ Misses 610 602 -8
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This one still makes sense after working on #8251 I'll merge it first and than rebase the other one so I get a good test of everything together |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 6ec4747 on top of patchback/backports/3.9/6ec4747a02955dbf227fb66f4419d124a37fcc71/pr-8200 Backporting merged PR #8200 into master
🤖 @patchback |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 6ec4747 on top of patchback/backports/3.10/6ec4747a02955dbf227fb66f4419d124a37fcc71/pr-8200 Backporting merged PR #8200 into master
🤖 @patchback |
Are there changes in behavior for the user?
Ensures the websocket transport is closed if the client never closes the connection after sending the CLOSE message
Is it a substantial burden for the maintainers to support this?
no
Related issue number
fixes #8184
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.