Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @asyncio.coroutine decorator with async def #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrnciar
Copy link

@hrnciar hrnciar commented Mar 1, 2022

In Python 3.11 @asyncio.coroutine decorator was removed and it should
be replaced with async def call.

This PR needs #278 if it ever gets merged.

What do these changes do?

Fixes tests for Python 3.11.

Are there changes in behavior for the user?

No

Related issue number

Fixes: #280

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

In Python 3.11 @asyncio.coroutine decorator was removed and it should
be replaced with async def call.

Fixes: aio-libs#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarnings with Python 3.8: "@coroutine" decorator
2 participants