Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-aiohttp in tests #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hroncok
Copy link

@hroncok hroncok commented Nov 14, 2019

Otherwise, we get:

E fixture 'aiohttp_client' not found

What do these changes do?

Add a test dependency on pytest-aiohttp.

Are there changes in behavior for the user?

No. Tests only.

Related issue number

I haven't opened one.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist - without his, the tests won't run
  • Documentation reflects the changes - not needed
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

There is no CHANGES folder.

Otherwise, we get:

E       fixture 'aiohttp_client' not found
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hroncok
Copy link
Author

hroncok commented Nov 16, 2020

This is not a nice response to a PR after 1 year. Consider my contribution Public Domain.

@JulienPalard
Copy link

I tested this PR and it correctly fixes pytest.PytestUnhandledCoroutineWarning: async def functions are not natively supported and have been skipped., it should be mergd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants