Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local tests #855

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Fix local tests #855

merged 9 commits into from
Jun 1, 2024

Conversation

eevelweezel
Copy link
Collaborator

@eevelweezel eevelweezel commented May 20, 2024

What do these changes do?

Fix tests to work locally with later versions of Docker.

Are there changes in behavior for the user?

No

Related issue number

#849, possibly #691

Checklist

  • [ x] I think the code is well written
  • [ x] Unit tests for the changes exist
  • [ x] Documentation reflects the changes
  • [ x] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [ x] Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@achimnol
Copy link
Member

FYI: https://github.com/actions/actions-runner-controller/blob/master/runner/actions-runner.ubuntu-22.04.dockerfile#L8
The Docker version in the action runner ubuntu-latest is 24.0.7 currently.

@achimnol
Copy link
Member

achimnol commented May 20, 2024

(oops)

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (94e6739) to head (4e9fb35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   81.44%   81.36%   -0.08%     
==========================================
  Files          24       24              
  Lines        1374     1374              
  Branches      245      245              
==========================================
- Hits         1119     1118       -1     
- Misses        169      170       +1     
  Partials       86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge the PR and inspect other local testing issues in my setup as a follow-up. Please check out my review comments!

tests/conftest.py Outdated Show resolved Hide resolved
tests/test_networks.py Outdated Show resolved Hide resolved
@eevelweezel eevelweezel requested a review from achimnol May 23, 2024 04:15
@achimnol achimnol merged commit 167301f into aio-libs:master Jun 1, 2024
12 checks passed
eevelweezel added a commit to eevelweezel/aiodocker that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants