Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache control arguments for cached_stampede #510

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JeppeKlitgaard
Copy link
Contributor

cached_stampede now features the same cache control arguments
as the cached decorator

`cached_stampede` now features the same cache control arguments
as the `cached` decorator
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #510 (d1668d3) into master (77976b0) will increase coverage by 42.82%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #510       +/-   ##
===========================================
+ Coverage   56.72%   99.55%   +42.82%     
===========================================
  Files          33       36        +3     
  Lines        2928     3564      +636     
  Branches      155      450      +295     
===========================================
+ Hits         1661     3548     +1887     
+ Misses       1243       12     -1231     
+ Partials       24        4       -20     
Flag Coverage Δ
unit 99.49% <66.66%> (+42.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiocache/decorators.py 98.70% <77.77%> (+20.18%) ⬆️
aiocache/plugins.py 100.00% <0.00%> (ø)
tests/acceptance/conftest.py 100.00% <0.00%> (ø)
tests/acceptance/test_lock.py 100.00% <0.00%> (ø)
tests/performance/conftest.py 100.00% <0.00%> (ø)
tests/acceptance/test_factory.py 100.00% <0.00%> (ø)
tests/acceptance/test_plugins.py 100.00% <0.00%> (ø)
tests/acceptance/test_decorators.py 100.00% <0.00%> (ø)
tests/performance/test_footprint.py 100.00% <0.00%> (ø)
tests/acceptance/test_serializers.py 100.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77976b0...d1668d3. Read the comment docs.

@argaen
Copy link
Member

argaen commented Oct 16, 2020

@JeppeKlitgaard thanks for this, mind adding tests? There should be ones for the cached decorator that you can just copy paste

@Dreamsorcerer
Copy link
Member

As mentioned, tests please, otherwise we'll close this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants