Skip to content

Commit

Permalink
Fix sphinx build (#392)
Browse files Browse the repository at this point in the history
Also add extra step in build pipeline to avoid future errors.
  • Loading branch information
argaen authored Apr 3, 2018
1 parent c0186d0 commit 1bbf3de
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 24 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ matrix:

- python: 3.6
env: TOXENV=syntax
- python: 3.6
env: TOXENV=docs-html

install:
- pip install tox
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ Contributing
#. Install dependencies with ``make install-dev`` (you will need ``pipenv`` which you can install with ``pip install pipenv``)
#. Make a change (means writing code, tests without reducing coverage and docs)
#. Ensure all tests pass with ``make test``. For fast iterations, use ``make unit`` which will build just the unit tests. You will need docker and docker-compose to be able to pass acceptance and functional tests.
#. Ensure documentation is OK with ``sphinx-autobuild docs/ docs/_build/html/``
#. Ensure documentation is OK with ``pipenv run sphinx-autobuild docs/ docs/_build/html/``
#. Make the PR in Github (you must have a fork of your own)
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ acceptance:
pipenv run pytest -sv tests/acceptance

doc:
make -C docs/ html
pipenv run make -C docs/ html

functional:
pipenv run bash examples/run_all.sh
Expand Down
17 changes: 0 additions & 17 deletions docs/conda_environment.yml

This file was deleted.

15 changes: 13 additions & 2 deletions docs/readthedocs.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,13 @@
conda:
file: conda_environment.yml
formats:
- none

build:
image: latest

python:
version: 3.6
pip_install: true
extra_requirements:
- redis
- memcached
- msgpack
6 changes: 3 additions & 3 deletions docs/serializers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ JsonSerializer

.. _msgpackserializer:

MessagePackSerializer
--------------
MsgPackSerializer
-----------------

.. autoclass:: aiocache.serializers.MessagePackSerializer
.. autoclass:: aiocache.serializers.MsgPackSerializer
:members:

In case the current serializers are not covering your needs, you can always define your custom serializer as shown in ``examples/serializer_class.py``:
Expand Down
12 changes: 12 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
envlist =
py{36}-{deps-lowest,deps-devel}
py{35,36}-ujson
codecov
syntax
docs-html


[testenv]
Expand Down Expand Up @@ -44,3 +47,12 @@ commands =
coverage combine
coverage report
codecov


[testenv:docs-html]
deps =
.[redis]
.[memcached]
.[msgpack]
.[dev]
commands = sphinx-build -b html -d {envtmpdir}/doctrees docs {envtmpdir}/html

0 comments on commit 1bbf3de

Please sign in to comment.